Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/token pair image #159

Merged
merged 9 commits into from
Jun 17, 2021
Merged

Feature/token pair image #159

merged 9 commits into from
Jun 17, 2021

Conversation

hachiojidev
Copy link
Contributor

@hachiojidev hachiojidev commented Jun 15, 2021 •
edited
Loading

image
image

@hachiojidev hachiojidev changed the title z1Feature/token pair image Feature/token pair image Jun 15, 2021
hachiojidev
hachiojidev commented Jun 16, 2021
View reviewed changes
packages/pancake-uikit/src/components/Image/Image.tsx Outdated
Comment on lines 25 to 29
const imgRef = useRef<HTMLImageElement>(null);
const [isLoaded, setIsLoaded] = useState(false);

useEffect(() => {
const img = imgRef.current as unknown as HTMLImageElement;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated typing

@hachiojidev hachiojidev marked this pull request as ready for review June 17, 2021 02:37
@hachiojidev hachiojidev merged commit 1eaf88e into master Jun 17, 2021
@hachiojidev hachiojidev deleted the feature/token-pair-image branch June 17, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RabbitDoge RabbitDoge RabbitDoge approved these changes

@Chef-Chungus Chef-Chungus Awaiting requested review from Chef-Chungus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hachiojidev @RabbitDoge